playground: Add missing supported packages. #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit ef99944, I've run update.sh to generate the latest playground. In the diff, it's visible that 3 files were removed: - playground/pkg/encoding/gob.a.js - playground/pkg/go/build.a.js - playground/pkg/go/doc.a.js That means they were previously built but not anymore with the latest version (possibly because the imports graph of standard library has changed in Go 1.5, so they are no longer dependencies, or possibly they were included erroneously). They are not explicitly listed in the list of packages to install and include. According to the current compatibility table, 2 of those 3 packages are supported (encoding/gob and go/doc). Add them to the update.sh script so they are included. Also add go/ast explicitly since it's supported. It was already built (as a dependency), but this will ensure it'll always be included even if it's no longer a dependency.
0582871 to
0760f83
Compare
|
I've tested the PR with this program and it works well. |
|
LGTM |
dmitshur
added a commit
that referenced
this pull request
Aug 29, 2015
playground: Add missing supported packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit ef99944, I've run update.sh to generate the latest playground. In the diff, it's visible that 3 files were removed:
That means they were previously built but not anymore with the latest version (possibly because the imports graph of standard library has changed in Go 1.5, so they are no longer dependencies, or possibly they were included erroneously). They are not explicitly listed in the list of packages to install and include.
According to the current compatibility table, 2 of those 3 packages are supported (encoding/gob and go/doc). Add them to the update.sh script so they are included.
Also add go/ast explicitly since it's supported. It was already built (as a dependency), but this will ensure it'll always be included even if it's no longer a dependency.